Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): run phpstan with 8.4 #1156

Merged
merged 3 commits into from
Nov 22, 2024
Merged

chore(dev): run phpstan with 8.4 #1156

merged 3 commits into from
Nov 22, 2024

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Nov 22, 2024

Summary

Doing so will in fact trigger a new error:

Deprecated in PHP 8.4: Parameter #2 $name (string) is implicitly nullable via default value null.

With #1155 I tried to make them better visible, but it's quite cumbersome and I found out, now with bumping the PHP version for phpstan, it's not covering everything. No idea why, but phpstan definitely reports all of the deprecations.

This is also in light of #1152 to have something more reliable.

Merge of this PR can only be done once #1152 is merged, then master merged into this PR and no errors reported anymore. If there still are, they need to be fixed too.


Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-assigned this Nov 22, 2024
@mfn mfn changed the title chore(dev): run phpstsan with 8.4 chore(dev): run phpstan with 8.4 Nov 22, 2024
@mfn mfn merged commit 50cdfe2 into master Nov 22, 2024
46 checks passed
@mfn mfn deleted the mfn-phpstan-8.4 branch November 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant